Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TorchServe IPEX blog #1880

Merged
merged 56 commits into from
Apr 15, 2022
Merged

TorchServe IPEX blog #1880

merged 56 commits into from
Apr 15, 2022

Conversation

min-jean-cho
Copy link
Contributor

final draft of TorchServe IPEX blog.

@msaroufim
Copy link
Member

msaroufim commented Mar 30, 2022

Hi @holly1238 I've been working on this blog with @min-jean-cho - we've done a technical review both at Meta and Intel. Let me know if you think is good to merge

EDIT: Seems like there's some CI issues, looking at the logs they feel unrelated https://app.circleci.com/pipelines/github/pytorch/tutorials/5781/workflows/a6c46699-5468-410a-aed9-5a8aec5be8a4/jobs/113446

@netlify
Copy link

netlify bot commented Mar 30, 2022

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 29fe185
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/6259b13e20d93c0008349ada
😎 Deploy Preview https://deploy-preview-1880--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@msaroufim
Copy link
Member

@min-jean-cho can we also make sure this blog shows up in one of these sections? pytorch/serve#1517

@min-jean-cho
Copy link
Contributor Author

min-jean-cho commented Apr 4, 2022

@min-jean-cho can we also make sure this blog shows up in one of these sections? pytorch/serve#1517

@msaroufim sounds good to me - how may I do so (is there another directory to which I should file another PR to) ?

@min-jean-cho min-jean-cho reopened this Apr 4, 2022
@holly1238
Copy link
Contributor

Hi @msaroufim! I'll add the tutorial to the left nav of the tutorials page, review/copy edit the blog, and look into the build issues early this week! (there may not be any build issues anymore, there was an issue that was breaking all the builds that was fixed last week)

@min-jean-cho can you sign the CLA agreement? That's needed to merge this PR. Thanks!

@min-jean-cho
Copy link
Contributor Author

@min-jean-cho can you sign the CLA agreement? That's needed to merge this PR. Thanks!

Hi @holly1238, thanks for the update. I have requested company CLA agreement on my behalf. This will take around 1 week. Thanks.

@min-jean-cho
Copy link
Contributor Author

Hi @holly1238, fyi I have made some minor changes (mostly grammatical, consistency, etc; the content itself is exactly the same). Please take into account when review/copy editing. Thank you.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@min-jean-cho
Copy link
Contributor Author

Hi @msaroufim and @holly1238 , the CLA has been signed now !

@msaroufim msaroufim merged commit 271b83a into pytorch:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants