Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PrivateUse1 Tutotial on integrating a new backend to pytorch via PrivateUse1 #2526

Merged
merged 8 commits into from
Oct 2, 2023

Conversation

FFFrog
Copy link
Contributor

@FFFrog FFFrog commented Aug 15, 2023

Includes a tutorial on how to integrate a new backend to pytorch via PrivateUse1.

It should be added that the tutorial uses Ascend NPU as an example, this is because we think that using npu instead of foo might be clearer for users or developers. Of course, we can change it back to foo if there's any argument or concern

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 15, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2526

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 15 Pending

As of commit 4da9c18 with merge base 420399d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @FFFrog!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@FFFrog
Copy link
Contributor Author

FFFrog commented Aug 15, 2023

@albanD, please have a look at this, thank you.

Copy link
Contributor

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content sounds good. Not sure why the CI is not working and would need to double check the rendered version.

@svekars svekars added the 2.1 label Aug 15, 2023
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! I added a few editorial suggestions. Let me know if you have any questions.

advanced_source/privateuseone.rst Outdated Show resolved Hide resolved
advanced_source/privateuseone.rst Outdated Show resolved Hide resolved
advanced_source/privateuseone.rst Outdated Show resolved Hide resolved
advanced_source/privateuseone.rst Outdated Show resolved Hide resolved
advanced_source/privateuseone.rst Outdated Show resolved Hide resolved
advanced_source/privateuseone.rst Outdated Show resolved Hide resolved
advanced_source/privateuseone.rst Outdated Show resolved Hide resolved
advanced_source/privateuseone.rst Outdated Show resolved Hide resolved
advanced_source/privateuseone.rst Outdated Show resolved Hide resolved
advanced_source/privateuseone.rst Show resolved Hide resolved
@FFFrog
Copy link
Contributor Author

FFFrog commented Aug 17, 2023

@svekars, thank you very much for your review, the new commit is ready, please take a look at it again :D

Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more super tiny nits and we should be good to go. Also, make sure the generated HTML looks good here.

advanced_source/privateuseone.rst Outdated Show resolved Hide resolved
advanced_source/privateuseone.rst Outdated Show resolved Hide resolved
advanced_source/privateuseone.rst Outdated Show resolved Hide resolved
advanced_source/privateuseone.rst Show resolved Hide resolved
advanced_source/privateuseone.rst Show resolved Hide resolved
index.rst Outdated Show resolved Hide resolved
@FFFrog
Copy link
Contributor Author

FFFrog commented Aug 18, 2023

@svekars, the generated HTML looks fine to me, please help to check it, thanks.

@FFFrog
Copy link
Contributor Author

FFFrog commented Aug 21, 2023

@svekars Sorry to bother you.

The deadline for August 25th is coming soon. If there is anything else that needs to be modified, please contact me, and I will modify it immediately.

Thank you.

@svekars
Copy link
Contributor

svekars commented Aug 22, 2023

The tutorial looks good to me. We typically merge tutorials in support of a release feature on the day of the release, which is scheduled for October 4.

@FFFrog
Copy link
Contributor Author

FFFrog commented Aug 24, 2023

The tutorial looks good to me. We typically merge tutorials in support of a release feature on the day of the release, which is scheduled for October 4.

Thank you for your comments.

@FFFrog
Copy link
Contributor Author

FFFrog commented Sep 1, 2023

Sorry to bother @svekars, I made a new commit to fix a tiny nits and rebase at the same time, please help to start the workflow.

@svekars svekars merged commit 1ca0ab5 into pytorch:main Oct 2, 2023
17 checks passed
@FFFrog FFFrog deleted the privateuse1 branch October 8, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants