-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PrivateUse1 Tutotial on integrating a new backend to pytorch via PrivateUse1 #2526
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2526
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 15 PendingAs of commit 4da9c18 with merge base 420399d (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @FFFrog! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
@albanD, please have a look at this, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content sounds good. Not sure why the CI is not working and would need to double check the rendered version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! I added a few editorial suggestions. Let me know if you have any questions.
@svekars, thank you very much for your review, the new commit is ready, please take a look at it again :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more super tiny nits and we should be good to go. Also, make sure the generated HTML looks good here.
@svekars, the generated HTML looks fine to me, please help to check it, thanks. |
@svekars Sorry to bother you. The deadline for August 25th is coming soon. If there is anything else that needs to be modified, please contact me, and I will modify it immediately. Thank you. |
The tutorial looks good to me. We typically merge tutorials in support of a release feature on the day of the release, which is scheduled for October 4. |
Thank you for your comments. |
Sorry to bother @svekars, I made a new commit to fix a tiny nits and rebase at the same time, please help to start the workflow. |
Includes a tutorial on how to integrate a new backend to pytorch via
PrivateUse1
.It should be added that the tutorial uses
Ascend NPU
as an example, this is because we think that usingnpu
instead offoo
might be clearer for users or developers. Of course, we can change it back tofoo
if there's any argument or concern