-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX 1] Add Backend section to the left page of Tutorials layout page #2550
[ONNX 1] Add Backend section to the left page of Tutorials layout page #2550
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2550
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f90ef02 with merge base 587c62a (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
bb362c2
to
58de789
Compare
#2541 will be added to this page as soon as it can be merged |
58de789
to
4bb92f6
Compare
@msaroufim FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm generally OK with having a tutorials/onnx
index page but having onnx be a in the left hand navigation is not something I'm as excited about since I'd then have to also be OK with other compiler vendors doing the same
Is there any way we can roll this content in to the deployment tab?
4bb92f6
to
b1034f1
Compare
If we could have submenus under We do understand the duality of ONNX, especially after pytorch 2.x series. On one hand, Also, because we introduced a new ONNX exporter based on Dynamo ( I hope that helps making our case :) |
b1034f1
to
7ce8fa9
Compare
Changed the left menu to |
Ping me when the doc renders I still don't see the most recent changes |
ping |
ok just stamped thanks! @svekars what's the convention for merging things in tutorials I forget what the policy is, do you tag things as 2.1 and wait until core does that upgrade to merge? |
Thanks! I will do an editorial pass. We will merge all 2.1 tutorials on the day of the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of nits.
7ce8fa9
to
5a8876a
Compare
nits fixed |
5a8876a
to
e56ba2e
Compare
a7bc59b
to
29d4650
Compare
This PR adds a `Backends` section to the left menu which initially will initially contain a placeholder for the series of ONNX export tutorials based on Torch Dynamo backend A table of content tree page will have static URL https://pytorch.org/tutorials/beginner/onnx/intro_onnx.html that will be referenced on PyTorch user document for torch.onnx module
29d4650
to
919356b
Compare
This PR adds a
Backends
section to the left menu which initially will have a placeholder for the series of ONNX export tutorials based on Torch Dynamo backendA table of content tree page will have static URL
https://pytorch.org/tutorials/beginner/onnx/intro_onnx.html
that will be referenced on PyTorch user document fortorch.onnx module
Following is a screenshot of the resulting page
Preview page: https://docs-preview.pytorch.org/pytorch/tutorials/2550/beginner/onnx/intro_onnx.html
Fixes: #2552