[ONNX 3] Add ONNX registry tutorial #2562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2562
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 020e25f with merge base 677c1b6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
justinchuby
reviewed
Sep 14, 2023
titaiwangms
force-pushed
the
titaiwang/add-onnx-registry-tutorial
branch
2 times, most recently
from
f6dae32
to
fc8262b
Compare
titaiwangms
force-pushed
the
titaiwang/add-onnx-registry-tutorial
branch
from
fc8262b
to
3a17a30
Compare
added 2 commits
September 20, 2023 15:35
This PR adds a `Backends` section to the left menu which initially will initially contain a placeholder for the series of ONNX export tutorials based on Torch Dynamo backend A table of content tree page will have static URL https://pytorch.org/tutorials/beginner/onnx/intro_onnx.html that will be referenced on PyTorch user document for torch.onnx module
titaiwangms
force-pushed
the
titaiwang/add-onnx-registry-tutorial
branch
from
3a17a30
to
1ad7170
Compare
svekars
reviewed
Sep 26, 2023
svekars
reviewed
Sep 26, 2023
svekars
reviewed
Sep 27, 2023
svekars
reviewed
Sep 28, 2023
| # | ||
| # | ||
| ###################################################################### | ||
| # Further reading |
There was a problem hiding this comment.
Suggested change
| # Further reading | |
| # Conclusion |
Please add an a description of what the user learned from this tutorial.
There was a problem hiding this comment.
Done. I added Conclusion above.
| # ---------------------------------------------- | ||
| # | ||
| # Now that we have our model saved in a file, we can visualize it with `Netron <https://github.com/lutzroeder/netron>`_. | ||
| # Netron can either be installed on macos, Linux or Windows computers, or run directly from the browser. |
There was a problem hiding this comment.
Suggested change
| # Netron can either be installed on macos, Linux or Windows computers, or run directly from the browser. | |
| # Netron can either be installed on macOS, Linux or Windows computers, or run directly from the browser. |
There was a problem hiding this comment.
Should we add macOS into en-wordlist.txt?
| @@ -132,6 +132,7 @@ Lipschitz | |||
| logits | |||
| Lua | |||
| Luong | |||
| macos | |||
There was a problem hiding this comment.
Suggested change
| macos |
This spelling is incorrect.
There was a problem hiding this comment.
Should we spell correctly or delete it?
There was a problem hiding this comment.
I see. We should use macOS instead. I can update all usage in this PR.
Update advanced_source/super_resolution_with_onnxruntime.py Small change to kick off the build Update advanced_source/super_resolution_with_onnxruntime.py Small fix, to kick off the build. Update beginner_source/onnx/export_simple_model_to_onnx_tutorial.py Small change Update beginner_source/onnx/onnx_registry_tutorial.py Co-authored-by: Svetlana Karslioglu <[email protected]> Update beginner_source/onnx/onnx_registry_tutorial.py Co-authored-by: Svetlana Karslioglu <[email protected]> Update beginner_source/onnx/onnx_registry_tutorial.py Co-authored-by: Svetlana Karslioglu <[email protected]> Update beginner_source/onnx/onnx_registry_tutorial.py Co-authored-by: Svetlana Karslioglu <[email protected]> Update beginner_source/onnx/onnx_registry_tutorial.py Co-authored-by: Svetlana Karslioglu <[email protected]> Update beginner_source/onnx/onnx_registry_tutorial.py Co-authored-by: Svetlana Karslioglu <[email protected]> Update beginner_source/onnx/onnx_registry_tutorial.py Co-authored-by: Svetlana Karslioglu <[email protected]> Update beginner_source/onnx/export_simple_model_to_onnx_tutorial.py Co-authored-by: Svetlana Karslioglu <[email protected]> Update beginner_source/onnx/onnx_registry_tutorial.py Co-authored-by: Svetlana Karslioglu <[email protected]> Update beginner_source/onnx/onnx_registry_tutorial.py Co-authored-by: Svetlana Karslioglu <[email protected]> Update beginner_source/onnx/onnx_registry_tutorial.py Co-authored-by: Svetlana Karslioglu <[email protected]> Update beginner_source/onnx/onnx_registry_tutorial.py Co-authored-by: Svetlana Karslioglu <[email protected]> Update beginner_source/onnx/onnx_registry_tutorial.py Co-authored-by: Svetlana Karslioglu <[email protected]> Update beginner_source/onnx/onnx_registry_tutorial.py Co-authored-by: Svetlana Karslioglu <[email protected]> Update beginner_source/onnx/onnx_registry_tutorial.py Co-authored-by: Svetlana Karslioglu <[email protected]> Update beginner_source/onnx/onnx_registry_tutorial.py Co-authored-by: Svetlana Karslioglu <[email protected]> added comments
titaiwangms
force-pushed
the
titaiwang/add-onnx-registry-tutorial
branch
from
0bd4de9
to
020e25f
Compare
|
Thanks for the super detail review on this tutorial!
To avoid merge conflicts with the previous two PRs (ONNX 1 and ONNX 2), this PR builds on top of them like ghstack. You can review the last commit. |
|
I apologize for closing this. Can you please resubmit against main? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #2541, this PR adds step by step guide to demonstrate end to end solution of how to address unsupported ATen/ONNX operators issue. Please review the last commit.
cc @thiagocrepaldi @abock @justinchuby @BowenBao @wschin