Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp TorchRec intro tutorial #3064

Merged
merged 31 commits into from
Oct 2, 2024
Merged

Revamp TorchRec intro tutorial #3064

Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
57ef3d0
Revamp TorchRec intro tutorial
PaulZhang12 Sep 27, 2024
7391cb1
Modify file type to .py
PaulZhang12 Sep 27, 2024
053e974
Update requirements
PaulZhang12 Sep 27, 2024
b4e940b
Address fixes
PaulZhang12 Sep 27, 2024
b5239c5
Address fixes 2
PaulZhang12 Sep 27, 2024
3e30cd2
Update builder hardware for torchrec tutorial
PaulZhang12 Sep 27, 2024
c7e857c
Move to run before ax tutorial
svekars Sep 27, 2024
3354612
Update .jenkins/metadata.json
svekars Sep 27, 2024
1b2502b
Update .jenkins/metadata.json
svekars Sep 27, 2024
e8409c2
Pin versions of torchrec/fbgemm
PaulZhang12 Sep 30, 2024
0302450
Bump torchao to 0.4.0
svekars Sep 30, 2024
b285551
Merge branch 'main' into main
svekars Oct 1, 2024
6ca1922
Update tutorial spelling
PaulZhang12 Oct 1, 2024
ed113b2
Address tutorial comments
PaulZhang12 Oct 1, 2024
b55441a
Address tutorial comments2
PaulZhang12 Oct 1, 2024
c56b686
Address tutorial comments3
PaulZhang12 Oct 1, 2024
dd47349
Address tutorial comments4
PaulZhang12 Oct 1, 2024
1551bc3
Address tutorial comments5
PaulZhang12 Oct 1, 2024
295b064
Address tutorial comments6
PaulZhang12 Oct 1, 2024
bf711b5
Fix cards
svekars Oct 2, 2024
fce26de
Update intermediate_source/torchrec_interactive_tutorial.py
svekars Oct 2, 2024
a67511b
Update intermediate_source/torchrec_interactive_tutorial.py
svekars Oct 2, 2024
6ce5bb2
Second editorial and formatting pass
svekars Oct 2, 2024
5e849c4
Update intermediate_source/torchrec_interactive_tutorial.py
svekars Oct 2, 2024
875c97b
Update torchrec_interactive_tutorial.py
svekars Oct 2, 2024
d4ed6bd
Fix format bullet points
PaulZhang12 Oct 2, 2024
e515272
Rename torchrec_interactive_tutorial.py to torchrec_intro_tutorial.py
svekars Oct 2, 2024
cafde35
Apply suggestions from code review
svekars Oct 2, 2024
7375f71
Update .jenkins/metadata.json
svekars Oct 2, 2024
dbef8ad
Merge branch 'main' into main
PaulZhang12 Oct 2, 2024
f799561
Update intermediate_source/torchrec_intro_tutorial.py
svekars Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .ci/docker/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,5 @@ pycocotools
semilearn==0.3.2
torchao==0.5.0
segment_anything==1.0
torchrec==0.8.0
fbgemm-gpu==0.8.0
3 changes: 3 additions & 0 deletions .jenkins/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@
"intermediate_source/model_parallel_tutorial.py": {
"needs": "linux.16xlarge.nvidia.gpu"
},
"intermediate_source/torchrec_interactive_tutorial.py": {
svekars marked this conversation as resolved.
Show resolved Hide resolved
"needs": "linux.g5.4xlarge.nvidia.gpu"
},
"recipes_source/torch_export_aoti_python.py": {
"needs": "linux.g5.4xlarge.nvidia.gpu"
},
Expand Down
29 changes: 29 additions & 0 deletions en-wordlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,3 +619,32 @@ warmup
webp
wsi
wsis
Meta's
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you run the sort command in vim (:sort), so it's sorted alphabetically.

RecSys
TorchRec
sharding
TBE
dtype
EBC
sharder
hyperoptimized
DMP
unsharded
lookups
KJTs
amongst
async
everytime
prototyped
GBs
HBM
gloo
nccl
Localhost
gpu
torchmetrics
url
colab
sharders
Criteo
torchrec
4 changes: 2 additions & 2 deletions index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,7 +846,7 @@ Welcome to PyTorch Tutorials
:header: Introduction to TorchRec
:card_description: TorchRec is a PyTorch domain library built to provide common sparsity & parallelism primitives needed for large-scale recommender systems.
:image: _static/img/thumbnails/torchrec.png
:link: intermediate/torchrec_tutorial.html
:link: intermediate/torchrec_interactive_tutorial.html
svekars marked this conversation as resolved.
Show resolved Hide resolved
:tags: TorchRec,Recommender

.. customcarditem::
Expand Down Expand Up @@ -1180,7 +1180,7 @@ Additional Resources
:hidden:
:caption: Recommendation Systems

intermediate/torchrec_tutorial
intermediate/torchrec_interactive_tutorial
svekars marked this conversation as resolved.
Show resolved Hide resolved
advanced/sharding

.. toctree::
Expand Down
Loading
Loading