Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make weight initialization optional to speed vgg-construction #377

Merged
merged 1 commit into from
Jan 2, 2018
Merged

make weight initialization optional to speed vgg-construction #377

merged 1 commit into from
Jan 2, 2018

Conversation

chenyuntc
Copy link
Contributor

@chenyuntc chenyuntc commented Dec 24, 2017 •
edited
Loading

_initialize_weights in vgg is time-consuming(about 9s in my laptop) and is usually not necessary. It's better to make it an optional argument.

alykhantejani
alykhantejani approved these changes Jan 2, 2018
View reviewed changes
Copy link
Contributor

@alykhantejani alykhantejani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9s seems very slow, but agreed this is an easy optimization to make

@alykhantejani alykhantejani merged commit 005bc47 into pytorch:master Jan 2, 2018
@alykhantejani
Copy link
Contributor

Thanks @chenyuntc

@soumith
Copy link
Member

soumith commented Jan 2, 2018

btw this is going to be sped up via pytorch/pytorch#4312 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alykhantejani alykhantejani alykhantejani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenyuntc @alykhantejani @soumith