Use --no-implicit-optional for type checking #6413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for PEP 484 compliant type checking (as of 2018). mypy will change its defaults soon. See python/mypy#9091
|
Hey @datumbox! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
datumbox
added
the
other
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
Summary: * Use --no-implicit-optional for type checking This is needed for PEP 484 compliant type checking (as of 2018). mypy will change its defaults soon. See python/mypy#9091 * forcing CI rerun Reviewed By: datumbox Differential Revision: D38824221 fbshipit-source-id: 2f786faadaedd7eaf0dd2147a9c575d1d86c9db0 Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes type checking PEP 484 compliant (as of 2018).
mypy will change its defaults soon.
See:
python/mypy#9091
python/mypy#13401