Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the file name for the FY-3F Mersi-3 RSRs #231

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

adybbroe
Copy link
Collaborator

@adybbroe adybbroe commented Jul 15, 2024

The purpose of this PR is to handle the fact that Pyspectral expects the RSR filename for Mersi-3 FY-3F to be rsr_mersi3_FY-3F.h5 rather than rsr_mersi-3_FY-3F.h5

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest pyspectral
  • Passes flake8 pyspectral
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@adybbroe adybbroe requested a review from simonrp84 July 15, 2024 10:39
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.82%. Comparing base (102a19f) to head (29663bc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   89.82%   89.82%           
=======================================
  Files          23       23           
  Lines        2535     2535           
=======================================
  Hits         2277     2277           
  Misses        258      258           
Flag Coverage Δ
unittests 89.82% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adybbroe adybbroe added the bug label Jul 15, 2024
@adybbroe adybbroe assigned adybbroe and unassigned adybbroe Jul 15, 2024
Copy link
Member

@simonrp84 simonrp84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adybbroe adybbroe merged commit 24fb83c into pytroll:main Jul 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants