Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused dependencies and deprecated code #232

Merged
merged 6 commits into from
Jul 20, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jul 18, 2024

Removed six and docutils dependencies that aren't used. Removed requirements.txt that isn't used. Remove old test suite code that isn't used. Remove deprecated setuptools things like test_requires.

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest pyspectral
  • Passes flake8 pyspectral
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese
Copy link
Member Author

djhoese commented Jul 18, 2024

@adybbroe I also noticed a lot of numpy deprecations. Are you OK if I fix those here or should I make another PR?

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.20%. Comparing base (29663bc) to head (d6b5c58).
Report is 2 commits behind head on main.

Files Patch % Lines
pyspectral/solar.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   89.82%   90.20%   +0.37%     
==========================================
  Files          23       23              
  Lines        2535     2521      -14     
==========================================
- Hits         2277     2274       -3     
+ Misses        258      247      -11     
Flag Coverage Δ
unittests 90.20% <81.25%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adybbroe
Copy link
Collaborator

@adybbroe I also noticed a lot of numpy deprecations. Are you OK if I fix those here or should I make another PR?

To me this sounds fine, doing it in this PR. Thanks!

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese djhoese added the bug label Jul 20, 2024
@djhoese djhoese merged commit 101113b into pytroll:main Jul 20, 2024
16 of 17 checks passed
@djhoese djhoese deleted the cleanup-deps branch July 20, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants