Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated numpy trapezoid/trapz usage with scipy trapezoid #233

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Aug 14, 2024

This PR completes the removal of deprecated trapz/np.trapezoid usage. It also sets the lower bound of the scipy dependency to 1.6.0 where trapz was renamed to trapezoid.

@djhoese djhoese added the bug label Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.25%. Comparing base (d6b5c58) to head (af71f1e).
Report is 5 commits behind head on main.

Files Patch % Lines
pyspectral/solar.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   90.20%   90.25%   +0.05%     
==========================================
  Files          23       22       -1     
  Lines        2521     2515       -6     
==========================================
- Hits         2274     2270       -4     
+ Misses        247      245       -2     
Flag Coverage Δ
unittests 90.25% <72.72%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djhoese
Copy link
Member Author

djhoese commented Aug 14, 2024

Adam and I had talked about the distutils change on slack and needing to release it. This is a similar change where numpy and scipy have both deprecated the "trapz" function in favor of "trapezoid" naming, but numpy is also suggesting people import and use scipy directly (one referenced the other, but my understanding it is all just scipy now).

@djhoese djhoese merged commit de18f70 into pytroll:main Aug 14, 2024
16 of 17 checks passed
@djhoese djhoese deleted the bugfix-trapz branch August 14, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate old scipy and remove use of trapz (numpy and scipy)
1 participant