Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sentinel-2C #234

Merged
merged 7 commits into from
Sep 24, 2024
Merged

Add support for Sentinel-2C #234

merged 7 commits into from
Sep 24, 2024

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented Sep 6, 2024

This PR adds support for the Sentinel-2C satellite.

In addition, the library used by the S2 RSR reader is outdated and does not work with XLSX files. So I changed to use pandas and openpyxl.

  • Tests passed: Passes pytest pyspectral
  • Passes flake8 pyspectral
  • Fully documented

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (af71f1e) to head (72f08bc).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files          22       22           
  Lines        2515     2515           
=======================================
  Hits         2270     2270           
  Misses        245      245           
Flag Coverage Δ
unittests 90.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonrp84
Copy link
Member Author

pre-commit.ci autofix

@mraspaud
Copy link
Member

mraspaud commented Sep 23, 2024

@adybbroe do you have the possibility to look at this?
Yes, looking at it now, sorry for forgetting!

Copy link
Collaborator

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for adding this!

@adybbroe
Copy link
Collaborator

And here is an example plotting the SW spectral responses for all three satellites
rsr_band_0040_0070

@adybbroe adybbroe merged commit b5bd38a into pytroll:main Sep 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants