Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated aerosol_type download_luts usage in rayleigh #235

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Sep 25, 2024

Not sure how this usage fell through the cracks, but download_luts's aerosol_type kwarg is deprecated. It should be aerosol_types=[X].

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest pyspectral
  • Passes flake8 pyspectral
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese
Copy link
Member Author

djhoese commented Sep 25, 2024

We should see how many other warnings are generated during tests and try to reduce it to zero. I ran into this deprecation running Satpy so there's another PR coming there.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (72f08bc) to head (a496559).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #235   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files          22       22           
  Lines        2515     2515           
=======================================
  Hits         2270     2270           
  Misses        245      245           
Flag Coverage Δ
unittests 90.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djhoese
Copy link
Member Author

djhoese commented Sep 25, 2024

@adybbroe Here we go, not bad at all:

pyspectral/tests/test_rad_tb_conversions.py::TestRadTbConversions::test_rad2tb
  /home/runner/miniconda3/envs/test-environment/lib/python3.12/site-packages/dask/core.py:133: RuntimeWarning: overflow encountered in exp
    return func(*(_execute_task(a, cache) for a in args))

pyspectral/tests/test_reflectance.py::TestReflectance::test_reflectance
  /home/runner/miniconda3/envs/test-environment/lib/python3.12/site-packages/numpy/ma/core.py:492: RuntimeWarning: invalid value encountered in cast
    fill_value = np.asarray(fill_value, dtype=ndtype)

The reflectance warning is probably a NaN. The overflow in the RadTbConversions is a little concerning.

Copy link
Collaborator

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this! That was a surprise this has been sitting there for so long.

@djhoese djhoese merged commit 01b55aa into pytroll:main Oct 8, 2024
17 checks passed
@djhoese djhoese deleted the bugfix-dep-aerosoltype branch October 8, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants