Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests where xarray was unable to guess backend engine #1592

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Mar 10, 2021

Our unstable CI tests started failing because pydata/xarray#4989 was merged. Xarray was no longer able to guess the backend engine for our tests that weren't using the .nc suffix even though the tests were created/using netcdf files. This PR fixes these tests.

  • Tests added
  • Fully documented

@djhoese djhoese self-assigned this Mar 10, 2021
@djhoese djhoese changed the title Fix tests that xarray was unable to guess backend engine for Fix tests where xarray was unable to guess backend engine Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #1592 (ece20d4) into master (f56a089) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1592   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files         253      253           
  Lines       37576    37577    +1     
=======================================
+ Hits        34844    34845    +1     
  Misses       2732     2732           
Flag Coverage Δ
behaviourtests 4.42% <0.00%> (-0.01%) ⬇️
unittests 92.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/reader_tests/test_vii_base_nc.py 98.73% <100.00%> (ø)
satpy/tests/reader_tests/test_vii_l1b_nc.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_vii_l2_nc.py 100.00% <100.00%> (ø)
satpy/tests/writer_tests/test_cf.py 99.69% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f56a089...ece20d4. Read the comment docs.

@ghost
Copy link

ghost commented Mar 10, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the quick reaction!

@mraspaud mraspaud merged commit 288c0bc into pytroll:master Mar 10, 2021
@djhoese djhoese deleted the bugfix-xr-engine-guess branch March 10, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants