-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QC-based filtering to the VIIRS EDR AOD550 product #2714
Conversation
@djhoese. A good test data set is here: See image here: ssec/polar2grid#666 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2714 +/- ##
=======================================
Coverage 95.39% 95.40%
=======================================
Files 371 371
Lines 52691 52749 +58
=======================================
+ Hits 50265 50323 +58
Misses 2426 2426
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 7469837169Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question inline. Also please ping me when this is finished from the p2g standpoint.
@mraspaud I commented on your question. Otherwise I think this is ready to go with the small fix I just committed. |
Polar2Grid PR: ssec/polar2grid#674 |
See ssec/polar2grid#666 for more information. Basically the AOD ("AOD550") product from the VIIRS EDR files looks a little "not good" by default. @kathys and I would like to play around with filtering it based on the
QCAll
QC variable in the file.@kathys I think as a starting point maybe you could point me to some data files of a good test case and I could generate images for all of the QC cases (0, 1, 2, 3 - default) and we see which looks best. I don't think it necessarily matters what Satpy uses in this PR as I've turned it off by default with the general practice Satpy has of not interfering with data coming from the files.