Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reset_image_cache #39

Merged
merged 3 commits into from
Jan 29, 2023
Merged

Fix reset_image_cache #39

merged 3 commits into from
Jan 29, 2023

Conversation

banesullivan
Copy link
Member

Resolve #38

@github-actions github-actions bot added the bug Something isn't working label Jan 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2023 •
edited
Loading

Codecov Report

Merging #39 (2bcda62) into main (d940270) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   90.21%   90.21%           
=======================================
  Files           2        2           
  Lines          92       92           
=======================================
  Hits           83       83           
  Misses          9        9
Impacted Files Coverage Δ
pytest_pyvista/pytest_pyvista.py 90.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MatthewFlamm
Copy link
Contributor

Added a test

MatthewFlamm
MatthewFlamm approved these changes Jan 29, 2023
View reviewed changes
Copy link
Contributor

@MatthewFlamm MatthewFlamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatthewFlamm
Copy link
Contributor

#36 will needs to consider this flag too. But we need to get the base functionality working before tackling the corner cases.

@banesullivan
Copy link
Member Author

Thanks for adding tests!

@banesullivan banesullivan merged commit acbfd2e into main Jan 29, 2023
@banesullivan banesullivan deleted the fix/reset_image_cache branch January 29, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewFlamm MatthewFlamm MatthewFlamm approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reset_image_cache is not working
3 participants
@banesullivan @codecov-commenter @MatthewFlamm