Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom error class #80

Merged
merged 9 commits into from
Sep 28, 2023

Conversation

germa89
Copy link
Contributor

@germa89 germa89 commented Sep 20, 2023

As the title.

Close #79

@github-actions github-actions bot added the enhancement New feature or request label Sep 20, 2023
@germa89
Copy link
Contributor Author

germa89 commented Sep 20, 2023

@pre-commit.ci autofix

Copy link
Contributor

@MatthewFlamm MatthewFlamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please use in the tests here too, I think there is only one spot currently. Also, can we add tests that these get raised?

.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
pytest_pyvista/pytest_pyvista.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Merging #80 (14aca43) into main (0ad5b8c) will increase coverage by 2.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   93.75%   96.00%   +2.25%     
==========================================
  Files           2        2              
  Lines          96      100       +4     
==========================================
+ Hits           90       96       +6     
+ Misses          6        4       -2     
Files Coverage Δ
pytest_pyvista/pytest_pyvista.py 95.91% <100.00%> (+2.30%) ⬆️

@MatthewFlamm MatthewFlamm mentioned this pull request Sep 28, 2023
@germa89
Copy link
Contributor Author

germa89 commented Sep 28, 2023

I think I'm done with this!

Copy link
Contributor

@MatthewFlamm MatthewFlamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlejandroFernandezLuces AlejandroFernandezLuces merged commit 9915001 into pyvista:main Sep 28, 2023
8 checks passed
AlejandroFernandezLuces added a commit that referenced this pull request Sep 29, 2023
* Support installation from Conda

* Remove vtk8 handling (#44)

* remove vtk8

* update readme

* remove from ci

* Align CI versions with pyvista CI

* Remove mention from documentation in readme

* Bump pydata-sphinx-theme from 0.12.0 to 0.13.1 (#48)

Bumps [pydata-sphinx-theme](https://github.com/pydata/pydata-sphinx-theme) from 0.12.0 to 0.13.1.
- [Release notes](https://github.com/pydata/pydata-sphinx-theme/releases)
- [Commits](pydata/pydata-sphinx-theme@v0.12.0...v0.13.1)

---
updated-dependencies:
- dependency-name: pydata-sphinx-theme
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump coverage from 7.0.5 to 7.2.1 (#45)

Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.0.5 to 7.2.1.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@7.0.5...7.2.1)

---
updated-dependencies:
- dependency-name: coverage
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump coverage from 7.2.1 to 7.2.2 (#52)

Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.2.1 to 7.2.2.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@7.2.1...7.2.2)

---
updated-dependencies:
- dependency-name: coverage
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add downstream tests and guard against leakages across tests (#49)

* Add downstream tests

* fix requirements install

* changes to working directory and software report

* narrow testing scope

* use dev version

* Temporarily use upstream branch

* Bug: guard against leaking verify_image_cache (#51)

* teardown fixture

* Fix teardown

* Teardown on errors

* update verbosity of tests temporarily

* Update ci_cd.yml

Partially remove verbosity

* use addfinalizer

* format

* use tmp branch

* Back to main branch

* Guard against leakages

* revert verbosity

* whitespace

* Update ci_cd.yml

use other branch

* Try latest python

* upload generated_images as artifact

* run upload on failure

* use same ubuntu version

* use main branch again

* Use main branch again

* add test

* Bump coverage from 7.2.2 to 7.2.3 (#57)

Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.2.2 to 7.2.3.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@7.2.2...7.2.3)

---
updated-dependencies:
- dependency-name: coverage
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump pydata-sphinx-theme from 0.13.1 to 0.13.3 (#56)

Bumps [pydata-sphinx-theme](https://github.com/pydata/pydata-sphinx-theme) from 0.13.1 to 0.13.3.
- [Release notes](https://github.com/pydata/pydata-sphinx-theme/releases)
- [Commits](pydata/pydata-sphinx-theme@v0.13.1...v0.13.3)

---
updated-dependencies:
- dependency-name: pydata-sphinx-theme
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump sphinx-copybutton from 0.5.1 to 0.5.2 (#58)

Bumps [sphinx-copybutton](https://github.com/executablebooks/sphinx-copybutton) from 0.5.1 to 0.5.2.
- [Release notes](https://github.com/executablebooks/sphinx-copybutton/releases)
- [Changelog](https://github.com/executablebooks/sphinx-copybutton/blob/master/CHANGELOG.md)
- [Commits](executablebooks/sphinx-copybutton@v0.5.1...v0.5.2)

---
updated-dependencies:
- dependency-name: sphinx-copybutton
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump coverage from 7.2.3 to 7.2.5 (#59)

Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.2.3 to 7.2.5.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@7.2.3...7.2.5)

---
updated-dependencies:
- dependency-name: coverage
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump pytest-cov from 4.0.0 to 4.1.0 (#61)

Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 4.0.0 to 4.1.0.
- [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-cov@v4.0.0...v4.1.0)

---
updated-dependencies:
- dependency-name: pytest-cov
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump coverage from 7.2.5 to 7.2.7 (#62)

Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.2.5 to 7.2.7.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@7.2.5...7.2.7)

---
updated-dependencies:
- dependency-name: coverage
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update numpy requirement from <1.24 to <1.26 (#63)

* Update numpy requirement from <1.24 to <1.26

Updates the requirements on [numpy](https://github.com/numpy/numpy) to permit the latest version.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst)
- [Commits](numpy/numpy@v0.2.0...v1.25.0)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* pin numpy for older vtk

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: MatthewFlamm <[email protected]>

* Fix CI; Remove python 3.7; remove flake8-isort (#66)

* remove python 3.7

* remove flake8-isort

* bump isort version

* pin sphinx (#67)

* [pre-commit.ci] pre-commit autoupdate (#64)

* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/psf/black: 22.10.0 → 23.7.0](psf/black@22.10.0...23.7.0)
- [github.com/pycqa/isort: 5.10.1 → 5.12.0](PyCQA/isort@5.10.1...5.12.0)
- [github.com/PyCQA/flake8: 5.0.4 → 6.1.0](PyCQA/flake8@5.0.4...6.1.0)
- [github.com/codespell-project/codespell: v2.2.2 → v2.2.5](codespell-project/codespell@v2.2.2...v2.2.5)
- [github.com/pycqa/pydocstyle: 6.1.1 → 6.3.0](PyCQA/pydocstyle@6.1.1...6.3.0)
- [github.com/pre-commit/mirrors-mypy: v0.982 → v1.5.1](pre-commit/mirrors-mypy@v0.982...v1.5.1)
- [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](pre-commit/pre-commit-hooks@v4.3.0...v4.4.0)
- [github.com/python-jsonschema/check-jsonschema: 0.18.4 → 0.24.1](python-jsonschema/check-jsonschema@0.18.4...0.24.1)

* mypy-extensions

* remove flake8-black

* Bump flake8-quotes

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Alex Kaszynski <[email protected]>
Co-authored-by: MatthewFlamm <[email protected]>

* [pre-commit.ci] pre-commit autoupdate (#70)

updates:
- [github.com/python-jsonschema/check-jsonschema: 0.24.1 → 0.26.3](python-jsonschema/check-jsonschema@0.24.1...0.26.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Bump sphinx-notfound-page from 0.8.3 to 1.0.0 (#71)

Bumps [sphinx-notfound-page](https://github.com/readthedocs/sphinx-notfound-page) from 0.8.3 to 1.0.0.
- [Changelog](https://github.com/readthedocs/sphinx-notfound-page/blob/main/CHANGELOG.rst)
- [Commits](readthedocs/sphinx-notfound-page@0.8.3...1.0.0)

---
updated-dependencies:
- dependency-name: sphinx-notfound-page
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump sphinx from 7.1.2 to 7.2.5 (#72)

* Bump coverage from 7.2.7 to 7.3.1 (#74)

Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.2.7 to 7.3.1.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@7.2.7...7.3.1)

---
updated-dependencies:
- dependency-name: coverage
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/checkout from 3 to 4 (#73)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#75)

updates:
- [github.com/psf/black: 23.7.0 → 23.9.1](psf/black@23.7.0...23.9.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Bump sphinx from 7.2.5 to 7.2.6 (#76)

Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 7.2.5 to 7.2.6.
- [Release notes](https://github.com/sphinx-doc/sphinx/releases)
- [Changelog](https://github.com/sphinx-doc/sphinx/blob/master/CHANGES)
- [Commits](sphinx-doc/sphinx@v7.2.5...v7.2.6)

---
updated-dependencies:
- dependency-name: sphinx
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Change dependency/CI version updates to monthly (#77)

* Change dependabot to monthly

* Update .pre-commit-config.yaml

* Bump codecov/codecov-action from 3 to 4 (#78)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v3...v4)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update LICENSE year (#81)

* Update LICENSE year

* Update ci_cd.yml

* Reset cache only if error (#82)

* Implementation

* Adding cli option

* Pre-commit fix

* feat: Add test for the new flag

* fix: Flag wasn't being captured

* fix: pre-commit issues

* fix: Remove print

* fix: Test image being overwritten

---------

Co-authored-by: afernand <[email protected]>

* Update README with conda/mamba install (#84)

* Update README with conda/mamba install

* Add conda-forge badge + icons

* Adding custom error class (#80)

* Adding custom error class

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Using codecov v3

* Removing init

* Reusing test to make sure the class is raised used. Adding test for file not found.

* Fixing test

* pre-commit fix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Typo fix geovista to pytest-pyvista (#88)

* Ad info about new flag (#87)

Co-authored-by: German <[email protected]>

* Bump version

* pre-commit fix

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: MatthewFlamm <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Alex Kaszynski <[email protected]>
Co-authored-by: Tetsuo Koyama <[email protected]>
Co-authored-by: German <[email protected]>
Co-authored-by: Bill Little <[email protected]>
Co-authored-by: German <[email protected]>
@germa89 germa89 deleted the feat/different-error branch October 2, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using a custom error class
4 participants