Hotfix v1.9.4 #2337
Closed
Hotfix v1.9.4 #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once we get the flake fixes in #2340 merged this will be ready to release. |
|
I've now cherry-picked the relevant flake fixes onto this branch. Should be ready to release now. |
|
All the PRs mentioned are now merged. Maybe it is worth also getting #2346 in as that is bug fixes too? |
|
Several of the items in #2346 look like they are for Elements not present in 1.9.4, though... |
|
That is a good point. If it is too much pain to cherry pick the commits that do apply to 1.9.4, then I suppose those fixes can simply be left out. |
|
That's okay, I'll remove those while cherry-picking. |
|
@jlstevens Now done, I think we can release this now. |
|
The key tests we expect to pass (flakes, nosetests) are now passing on both Python 2 and 3. I'm now preparing the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately a regression in the regrid operation was introduced in the hotfix 1.9.3 branch. This PR represents the fixes for that branch, and should not be merged.
Other PRs that would be good to get into this release are:
The latter would be good to ensure that we are actually testing against the latest versions of different libraries, which is what caused the
regridbug to slip through.