Fix phase list when initializing CrystalMap with a sparse phase list #433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This is a fix for a bug spotted by @Erlendos12 in pyxem/kikuchipy#620. When a
CrystalMap
is initialized with a phase ID array with more IDs than there are phases in the given phase list, the returned map does not link the phase ID array with the correct phase in the phase list. It does with this fix. See below for an example.I'd like to release a 0.11.1 patch with this fix as soon as this PR is merged onto
main
, if that is OK with people.Progress of the PR
html_theme_options
in v0.13.0 pydata/pydata-sphinx-theme#1220Minimal example of the bug fix or new feature
This example is also an added test.
For reviewers
__init__.py
.section in
CHANGELOG.rst
.__credits__
inorix/__init__.py
and in.zenodo.json
.