Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create vectors from path ends #445

Merged
merged 3 commits into from
May 2, 2023

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented Apr 22, 2023

Description of the change

  • Add class method to obtain vectors drawing a path between two vectors on the sphere. This is useful when delineating a path or the border of a spherical region in the stereographic projection or in 3D.
  • Make the polar stereographic grid use Matplotlib's grid.alpha parameter
  • Add an example showing how to combine rotations. This example is the same as in the paper by Rowenhorst et al. (2015) showing the difference between active and passive rotations. In that paper they use mainly passive rotations. We do the same in orix. This means rotations are combined from left to right, as in rAB = rA * rB, where rotations are done in A, B order.

These changes were originally added in #442. The main change in that PR has to wait for other changes before we can continue with it, so I'm making separate PRs for the changes that we can merge now.

Progress of the PR

Minimal example of the bug fix or new feature

See the new example on combining rotations to see all the changes in this PR in action: https://orix--445.org.readthedocs.build/en/445/examples/rotations/combine_rotations.html

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • Contributor(s) are listed correctly in __credits__ in orix/__init__.py and in
    .zenodo.json.

@hakonanes hakonanes added bug Something isn't working enhancement New feature or request documentation Relates to the documentation labels Apr 22, 2023
@hakonanes hakonanes added this to the v0.12.0 milestone Apr 22, 2023
Copy link
Collaborator

@harripj harripj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hakonanes hakonanes merged commit b879afd into pyxem:develop May 2, 2023
@hakonanes hakonanes deleted the create-vectors-from-path-ends branch May 2, 2023 11:57
@hakonanes
Copy link
Member Author

Thank you for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Relates to the documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants