Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow regex usage in the "excludePathsFromReport" option #294

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

ismarbesic
Copy link
Contributor

@ismarbesic ismarbesic commented Aug 9, 2023

This PR adds regex usage for the "excludePathsFromReport" option instead of using plain strings. Current tests are passing and another test for the regex has been added. Since the paths are split by semi-colons, it does not take into account if the regex itself contains a semi-colon. This could be improved so that we only use a regex, or just introduce another variable for a regex only, but that means there will be breaking changes.

Closes #293.

@ismarbesic ismarbesic temporarily deployed to prod August 9, 2023 15:56 — with GitHub Actions Inactive
@ismarbesic ismarbesic temporarily deployed to prod August 9, 2023 15:56 — with GitHub Actions Inactive
@ismarbesic ismarbesic temporarily deployed to prod August 9, 2023 15:56 — with GitHub Actions Inactive
@ismarbesic ismarbesic temporarily deployed to prod August 9, 2023 15:56 — with GitHub Actions Inactive
@ismarbesic ismarbesic temporarily deployed to prod August 9, 2023 15:56 — with GitHub Actions Inactive
@ismarbesic ismarbesic temporarily deployed to prod August 9, 2023 15:56 — with GitHub Actions Inactive
@ismarbesic ismarbesic temporarily deployed to prod August 9, 2023 15:56 — with GitHub Actions Inactive
@ismarbesic ismarbesic temporarily deployed to prod August 9, 2023 15:56 — with GitHub Actions Inactive
@mrseanryan
Copy link
Collaborator

Looks good!

To be on safe side, will release as major version

@mrseanryan mrseanryan merged commit 4b37c10 into pzavolinsky:master Aug 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "excludePathsFromReport" option does not support regex
2 participants