Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple marks #5

Open
1 of 2 tasks
wvengen opened this issue Sep 19, 2018 · 1 comment
Open
1 of 2 tasks

Handle multiple marks #5

wvengen opened this issue Sep 19, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@wvengen
Copy link
Member

wvengen commented Sep 19, 2018

A small number of products has multiple mark symbols. Currently only one is supported.

  • Rename mark to marks and make it an array (for future API compatibility)
  • Fully recognize and handle multiple marks

An example is Dr. Bronner's Shikakai soap teatree with ingredients:

INCI: Vitis Vinifera Juice*, Sucrose*^, Cocos Nucifera Oil* (***), Potassium Hydroxide, Olea Europaea* (***), Melaleuca Alternifolia*, Accacia Concinna (Shikakai) Nut Powder*, Citric Acid, Cannabis Sativa Seed Oil*, Buxus Chinensis (Jojoba) Seed Oil*, Tocopherols (vitaminw E), d-Limonene***. * Van biologische herkomst *** Etherische olie ^ Volgens fairtrade-normen verhandeld

and

Water, groentenª¹ 26,3% (broccoli 17,2%, erwt 2,5%, prei, ui 2,6%, spinazie), aardappelª¹, ROOMª 5,9%, maïszetmeelª, raapzaadolieª, zout, rietsuikerª, gistextract, nootmuskaatª, aroma, ª afkomstig van gecontroleerde biologische landbouw., ¹op duurzame wijze geteeld.

@wvengen wvengen added the enhancement New feature or request label Sep 19, 2018
@wvengen
Copy link
Member Author

wvengen commented Jul 11, 2024

A repitition of a single character in a mark would still be one mark, when there are different marks after each other, they are different. Then there is the bracketed notation for multiple marks (let's limit this to two note marks, as we'd need examples, e.g. would it be * (***) (****) or * (***, ****) or (*, ***, ****)?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant