Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log reader #137

Merged
merged 6 commits into from
Aug 19, 2021
Merged

Log reader #137

merged 6 commits into from
Aug 19, 2021

Conversation

nwittler
Copy link
Collaborator

@nwittler nwittler commented Aug 18, 2021

What

Updated and added example for the log reader CLI. Added the option to specify a wait interval when watching a log file.

Why

Addresses #17

Remarks

This is a minor addition for documentation and changes no functionality.

Checklist

Please include and complete the following checklist. Your Pull Request is (in most cases) not ready for review until the following have been completed. You can create a draft PR while you are still completing the checklist. Check the Contribution Guidelines for more details. You can mark an item as complete with the - [x] prefix

  • Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
  • Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
  • Type Annotations - All new code has been type annotated in the function signatures using type hints
  • Docstrings - Docstrings have been provided for functions in the numpydoc style
  • Documentation - The tutorial style documentation has been updated to explain changes & new features
  • Notebooks - Example notebooks have been updated to incorporate changes and new features
  • Changelog - A short note on this PR has been added to the Upcoming Release section

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #137 (a2771fa) into dev (dcdb2be) will increase coverage by 0.61%.
The diff coverage is 23.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #137      +/-   ##
==========================================
+ Coverage   70.81%   71.43%   +0.61%     
==========================================
  Files          36       36              
  Lines        5222     5219       -3     
==========================================
+ Hits         3698     3728      +30     
+ Misses       1524     1491      -33     
Impacted Files Coverage Δ
c3/utils/log_reader.py 63.82% <23.80%> (+63.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcdb2be...a2771fa. Read the comment docs.

@nwittler nwittler merged commit 2b4625f into q-optimize:dev Aug 19, 2021
@nwittler nwittler deleted the log-reader branch August 19, 2021 12:54
@lazyoracle lazyoracle mentioned this pull request Nov 12, 2021
@lazyoracle lazyoracle added this to the 1.4 milestone Dec 7, 2021
@lazyoracle lazyoracle mentioned this pull request Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants