Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.6 #156

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Conversation

lazyoracle
Copy link
Member

@lazyoracle lazyoracle commented Nov 30, 2021

What

Drop Support for Python 3.6

Why

Closes #155

How

Stop running tests and publishing releases for Python 3.6

Remarks

It should still be possible to install and use c3-toolset with Python 3.6 if one explicitly installs tensorflow<=2.6 and tensorflow-probability<=0.14 and then installs c3-toolset. However, going forward, we no longer officially support or test our builds in Python 3.6 or lower.

Checklist

Please include and complete the following checklist. Your Pull Request is (in most cases) not ready for review until the following have been completed. You can create a draft PR while you are still completing the checklist. Check the Contribution Guidelines for more details. You can mark an item as complete with the - [x] prefix

  • Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
  • Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
  • Type Annotations - All new code has been type annotated in the function signatures using type hints
  • Docstrings - Docstrings have been provided for functions in the numpydoc style
  • Documentation - The tutorial style documentation has been updated to explain changes & new features
  • Notebooks - Example notebooks have been updated to incorporate changes and new features
  • Changelog - A short note on this PR has been added to the Upcoming Release section

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #156 (669a215) into dev (0a91ad4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #156   +/-   ##
=======================================
  Coverage   71.41%   71.41%           
=======================================
  Files          36       36           
  Lines        5220     5220           
=======================================
  Hits         3728     3728           
  Misses       1492     1492           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a91ad4...669a215. Read the comment docs.

@lazyoracle lazyoracle merged commit 1e5de95 into q-optimize:dev Dec 6, 2021
@lazyoracle lazyoracle deleted the drop-py-3.6 branch December 6, 2021 14:19
@lazyoracle lazyoracle added this to the 1.4 milestone Dec 7, 2021
@lazyoracle lazyoracle mentioned this pull request Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tensorflow 2.7 drops support for Python 3.6 and lower
2 participants