Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions written to the Actor log do not include the Actor prefix. #255

Open
2 tasks done
Pressacco opened this issue Mar 9, 2023 · 1 comment
Open
2 tasks done
Labels
bug Something isn't working

Comments

@Pressacco
Copy link
Contributor

Pressacco commented Mar 9, 2023

Background

  • The Screenplay Actor generates a nice "plain English" log file which can be reviewed post-test run.

Actual Behavior

The following is missing when the response to a question is logged:

  1. The actor's name.
  2. Context.
2023-03-09 20:47:07Z [INFO] Adding Ability for 'Dr. Watson' to build widgets.
2023-03-09 20:47:07Z [INFO] 'Dr. Watson' attempts to focus on WidgetApp.exe
2023-03-09 20:47:10Z [INFO] 'Dr. Watson' asking for 'CreateButton' is enabled
2023-03-09 20:47:10Z [INFO]  'CreateButton' is enabled was True

Expected behavior

For consistency, all log entries should be prefixed with:

  1. The actor's name (e.g. 'Dr. Watson').
  2. Context (e.g. observed that the).
2023-03-09 20:47:07Z [INFO] Adding Ability for 'Dr. Watson' to build widgets.
2023-03-09 20:47:07Z [INFO] 'Dr. Watson' attempts to focus on WidgetApp.exe
2023-03-09 20:47:10Z [INFO] 'Dr. Watson' asking for 'CreateButton' is enabled
2023-03-09 20:47:10Z [INFO] 'Dr. Watson' observed that the 'CreateButton' is enabled was True

Steps to reproduce

None at this time.

Boa Constrictor version

3.0.3

Browsers

No response

Operating systems

Windows

Anything else?

On Discord AutomationPanda suggested that I create a Pull Request.

Commitments

  • I agree to follow Boa Constrictor's Code of Conduct.
  • I want to work on this issue myself. (This is voluntary, not required.)
@Pressacco Pressacco added the bug Something isn't working label Mar 9, 2023
Pressacco added a commit to Pressacco/boa-constrictor that referenced this issue Mar 10, 2023
Pressacco added a commit to Pressacco/boa-constrictor that referenced this issue Mar 10, 2023
Pressacco added a commit to Pressacco/boa-constrictor that referenced this issue Mar 10, 2023
Pressacco added a commit to Pressacco/boa-constrictor that referenced this issue Mar 10, 2023
@AutomationPanda
Copy link
Contributor

Like #257 , this is a really good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants