Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: amount is nil in GetTotalWeight + misc lint issues #517

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Z3rio
Copy link
Contributor

@Z3rio Z3rio commented May 25, 2024

Description

Upon running /giveitem 1 radio 1, you'll run into the following error.
image
(First print is raw item json, second print is weight & amount)

Perhaps this should be looked into more deeply, as the amount value should be defined here.
Aswell as the fact that this error might be happening at other places

Perhaps, this is caused by the radio being a unique item?

Checklist

  • I have personally loaded this code into an updated qbcore project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

@Z3rio
Copy link
Contributor Author

Z3rio commented May 25, 2024

That last nil value in the lint report is fixed by my other PR.

@Z3rio Z3rio changed the title fix: amount is nil in GetTotalWeight fix: amount is nil in GetTotalWeight + misc lint issues May 25, 2024
@ChristianBDev
Copy link
Contributor

I have personally tried this and cannot replicate the issue, how recent is all your qb files? If up to date is there any errors before this?

@Z3rio
Copy link
Contributor Author

Z3rio commented May 25, 2024

I have personally tried this and cannot replicate the issue, how recent is all your qb files? If up to date is there any errors before this?

Ran a completely fresh install a couple minutes before this.

@Z3rio
Copy link
Contributor Author

Z3rio commented Jul 15, 2024

Perhaps this issue was caused by going from the old inventory and such, to the new inventory.
Nevertheless, its an issue that did occur for me, under normal usage circumstances

@GhzGarage GhzGarage self-assigned this Jul 25, 2024
@GhzGarage GhzGarage added help wanted Extra attention is needed invalid This doesn't seem right labels Jul 25, 2024
Copy link

This PR has had 60 days of inactivity & will close within 7 days

@github-actions github-actions bot added the Stale label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed invalid This doesn't seem right Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants