Enable user to navigate within the pages of an experiment via navigation stepper #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…side-an-experiment
…side-an-experiment
…side-an-experiment
sven1103
reviewed
Nov 10, 2023
| log.debug(String.format( | ||
| "New instance for ExperimentInformationMain (#%s) created with ProjectNavigationBar Component (#%s), ExperimentMain component (#%s) and ExperimentSupport component (#%s)", |
There was a problem hiding this comment.
Please use variables to reference class names, since they are mutable and can change. getClass().getName() sth like that
There was a problem hiding this comment.
Oh good point! I took the liberty and adapted all class instantiation logs in this commit in a similiar way.
…side-an-experiment
…' of https://github.com/qbicsoftware/data-manager-app into feature/dm-1002-provide-navigation-inside-an-experiment
|
Kudos, SonarCloud Quality Gate passed!
|
sven1103
approved these changes
Nov 10, 2023
Steffengreiner
deleted the
feature/dm-1002-provide-navigation-inside-an-experiment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
1.) Introduce dedicated AppLayout
ExperimentMainLayoutfor all pages within an ExperimentThis AppLayout hosts the
ProjectSideNavigationComponentin its Drawer Section and the `ExperimentNavigationComponent' in its Navbar section.2.) Adapt Routing to the
SampleMainComponentfrom
projects/:projectId?/samplestoprojects/:projectId?/experiments/:experimentId?/samplesSince the component is planned to show the batch information within an experiment instead of all experiment information within a project. This is also necessary so the
ExperimentNavigationComponentknows the pages of which experiment it should route to.3.) Remove
ProjectNavigationBarComponentNo longer necessary since it's replaced with 'ExperimentNavigationComponent', this also means that the CSS for all main components was adapted to remove the space within the pages CSS layout grid allocated to the
ProjectNavigationBarComponent.4.) Minor adaptions to the component routing
We can now expect an
ExperimentIdto be present when navigating between the pages of an experiment, therefore the routing in all components and considering the beforeEnterEvents will throw an exception if no validExperimentIdwas required.Technical Limitations and Bugs
1.) Active Experiment within the
SideNavcomponent is not highlighted correctly if the user switches to theExperimentInformationPagewithin the experiment via theExperimentNavigationComponent:Bildschirmaufnahme.2023-11-07.um.14.19.58.mov
This seems to be a bug within the SideNavComponent which will hopefully be addressed by Vaadin in the future.
Sadly currently the SideNav component also does not provide the API to set an active Item directly so we can't do an easy workaround for now.
2.) Selecting an experiment via the tab within the SampleGrid does not update the active experiment in the SideNavComponent
Bildschirmaufnahme.2023-11-07.um.14.19.34.mov
This was not implemented since we plan to replace the experiment tabs within the sample grid with tabs showing batch information instead.