-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraform module gcp compute engine #33
Conversation
@@ -0,0 +1,13 @@ | |||
module "compute_engine" { | |||
source = ".../.../gcp/modules/compute_engine" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls change to ../../modules/compute_engine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qburst-praven This is done
@@ -0,0 +1,16 @@ | |||
|
|||
variable "name"{ | |||
type=string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add defaults for all variables, "" in this case. Please update the README with the same.
Also, please run terraform fmt --recrusive against the terraform folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qburst-praven Formatting is done and changes committed
Terraform Plan :
module.compute_engine.google_compute_instance.compute_engine will be created
can_ip_forward = false
cpu_platform = (known after apply)
current_status = (known after apply)
deletion_protection = false
guest_accelerator = (known after apply)
id = (known after apply)
instance_id = (known after apply)
label_fingerprint = (known after apply)
machine_type = "e2-medium"
metadata_fingerprint = (known after apply)
min_cpu_platform = (known after apply)
name = "Qburst-DevOps"
project = (known after apply)
self_link = (known after apply)
tags = [
]
tags_fingerprint = (known after apply)
zone = "us-central1-a"
boot_disk {
auto_delete = true
device_name = (known after apply)
disk_encryption_key_sha256 = (known after apply)
kms_key_self_link = (known after apply)
mode = "READ_WRITE"
source = (known after apply)
initialize_params {
}
}
}
network_interface {
}
service_account {
]
}
}
module.compute_engine.google_service_account.computeengine_sa will be created
}
Plan: 2 to add, 0 to change, 0 to destroy.
Changes to Outputs:
}