Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small alazar fixes #83

Merged
merged 15 commits into from
May 22, 2018
Merged

Conversation

jenshnielsen
Copy link
Contributor

Add real and imaginary part. Remove strange 0 and add some examples

@ThorvaldLarsen
Copy link
Collaborator

A couple more comments to the driver.

  • When initilising the setup it sometimes freezes when trying to update data parameter for the alazar channels to the station.
  • I get this warning anytime I want to take data by calling .data on a channellist: py.warnings - WARNING - C:\Users\t3user\Qcodes\qcodes\instrument\parameter.py:1107: UserWarning: MultiParameters do not support set at this time. warnings.warn('MultiParameters do not support set at this time.')

@ThorvaldLarsen
Copy link
Collaborator

Would it be possible to change the name of 'x' and 'y' to either real/imag or I/Q to keep consistent with the lingo in RF demodulation?

@jenshnielsen
Copy link
Contributor Author

Sure I have no preference

@ThorvaldLarsen
Copy link
Collaborator

I have a couple of request:

  • Can we make label and unit of the .data parameter depend on demod_type? So that the label will be e.g. Imaginary (V) or Phase (degree) automatically after changing demod_type?
  • Would it be possible to include an update to the ATS9360_ext driver, which has the seq_mode parameter, in this PR to reflect the new setup with settings defined in the yaml file instead? Maybe @nataliejpg has an opinion on updating it.
  • Getting snapshot update warnings from 0D parameters. Solved by adding snapshot_get=False in the super.init call of Alazar0DParameter. (snapshot_get = False is default for ArrayParameters so there is no problem with AlazarNDParameter.)
  • With the current driver I can simultaneously take data from all channels or slices of channels. Is it also possible to take data from an arbitrary set of channels?

@nataliejpg
Copy link
Collaborator

an update so that we can still use the seq_mode sounds great. I don't think there is much to have an opinion on other then that it should be implemented ;)

Otherwise all sounds good.

@nataliejpg
Copy link
Collaborator

although I would make the argument that we should merge the fixes and make another pull request for the outstanding things because of the *0 bug which it's pretty urgent to get fixed in the master branch (I totally underestimated this which caused a lot of time lost for T2 people and I'm trying to learn my lesson)

@ThorvaldLarsen
Copy link
Collaborator

In my list the only critical part is:
Getting snapshot update warnings from 0D parameters. Solved by adding snapshot_get=False as argument in super().init call of Alazar0DParameter.

I agree that the rest can follow in a later PR.

@Dominik-Vogel
Copy link
Contributor

@ThorvaldLarsen can you post or/and explain the warning? I am happy to add this and merge the PR if the warning really does not make any sense in this context and we don't get side effects from setting snapshot_get to false.

@ThorvaldLarsen
Copy link
Collaborator

it tries to update alazar_chan.data during the initialization script which it should not be doing. This results in a warning saying that it could not update the snapshot for alazar_chan.data.
Does that explain it? Otherwise we should just quickly meet at T3 and I can show it.

@nataliejpg
Copy link
Collaborator

just wondering if there's a reason we haven't merged this yet?

@ThorvaldLarsen
Copy link
Collaborator

Yes, the part mentioned in my previous post is not changed yet.

@nataliejpg
Copy link
Collaborator

right, my mistake. If it's not going to get fixed in the next week though I would argue for merging and making a separate pr. I can see it's annoying to get warnings but the *0 fix is so important I don't think it should stay out of the main branch for any reason.

@nataliejpg
Copy link
Collaborator

@Dominik-Vogel is a fix in the next week feasible? If not what's your opinion on merging already? You have the deciding vote ;)

@ThorvaldLarsen
Copy link
Collaborator

This is a 5 min thing. So if we don't have time for that then I assume we dont have to merge either.

@nataliejpg
Copy link
Collaborator

5 mins > 1 second

@ThorvaldLarsen
Copy link
Collaborator

Well, T2 is open atm so I am sure it can wait a bit longer and then get the changes I requested by my test instead of merging a non-working PR.

@nataliejpg
Copy link
Collaborator

I think it's a really important fix that should be merged as soon as possible and that waiting more than another week isn't an option.

@Dominik-Vogel Dominik-Vogel merged commit 2a10065 into qdev-dk:master May 22, 2018
@ThorvaldLarsen ThorvaldLarsen mentioned this pull request May 22, 2018
4 tasks
@jenshnielsen jenshnielsen deleted the small_alazar_fixes branch May 22, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants