Feature/prospective parachains multi candidates #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iceseer
force-pushed
the
feature/prospective_parachains_multi_candidates
branch
from
0cc14d5
to
4d59039
Compare
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
iceseer
force-pushed
the
feature/prospective_parachains_multi_candidates
branch
from
4d59039
to
0c43fea
Compare
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: iceseer <[email protected]>
…_parachains_multi_candidates
…pective_parachains_multi_candidates
iceseer
force-pushed
the
feature/prospective_parachains_multi_candidates
branch
from
0ee4703
to
48853ac
Compare
Signed-off-by: iceseer <[email protected]>
iceseer
force-pushed
the
feature/prospective_parachains_multi_candidates
branch
from
48853ac
to
fd3e6c6
Compare
Signed-off-by: iceseer <[email protected]>
…_parachains_multi_candidates Signed-off-by: iceseer <[email protected]> # Conflicts: # core/parachain/pvf/pvf_impl.cpp # core/parachain/pvf/pvf_impl.hpp # core/runtime/common/runtime_instances_pool.cpp # test/core/parachain/pvf_test.cpp
iceseer
force-pushed
the
feature/prospective_parachains_multi_candidates
branch
from
3d2b2e9
to
a97547e
Compare
Signed-off-by: iceseer <[email protected]>
iceseer
force-pushed
the
feature/prospective_parachains_multi_candidates
branch
from
a97547e
to
7bdfca4
Compare
xDimon
approved these changes
Apr 5, 2024
| @@ -193,6 +193,8 @@ namespace kagome::network { | |||
| */ | |||
| virtual std::optional<std::reference_wrapper<PeerState>> getPeerState( | |||
| const PeerId &peer_id) = 0; | |||
| virtual std::optional<std::reference_wrapper<const PeerState>> getPeerState( | |||
There was a problem hiding this comment.
Perhaps, non-const method is not used and might be deleted
There was a problem hiding this comment.
Нужен для изменения версии и стауса коллатора.
Signed-off-by: iceseer <[email protected]>
kamilsa
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1993
Description of the Change
Provide multiple candidates from fragment tree
Ref: paritytech/polkadot-sdk#3160