Fix/kusama grid size fixes #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: turuslan <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
iceseer
force-pushed
the
fix/kusama_backed_candidates
branch
from
6b81857
to
7063722
Compare
Signed-off-by: iceseer <[email protected]>
iceseer
force-pushed
the
fix/kusama_backed_candidates
branch
from
74af161
to
59b80b6
Compare
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
…s' into fix/kusama_backed_candidates Signed-off-by: iceseer <[email protected]> # Conflicts: # core/authority_discovery/query/query_impl.cpp # core/network/impl/protocols/protocol_fetch_available_data.hpp # core/parachain/availability/recovery/recovery_impl.cpp # core/parachain/availability/recovery/recovery_impl.hpp # core/parachain/validator/impl/parachain_processor.cpp
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
iceseer
force-pushed
the
fix/kusama_backed_candidates
branch
from
300c96c
to
ff86a15
Compare
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
…andidates Signed-off-by: iceseer <[email protected]> # Conflicts: # core/log/formatters/optional.hpp # core/parachain/approval/approval_distribution.cpp # core/parachain/availability/recovery/recovery_impl.cpp # core/parachain/validator/impl/parachain_processor.cpp # core/parachain/validator/parachain_processor.hpp
iceseer
force-pushed
the
fix/kusama_backed_candidates
branch
9 times, most recently
from
529a475
to
a5fda88
Compare
Signed-off-by: iceseer <[email protected]>
iceseer
force-pushed
the
fix/kusama_backed_candidates
branch
from
a5fda88
to
97ed05a
Compare
turuslan
approved these changes
Oct 1, 2024
| /// update peers in grid view | ||
| const auto &grid_view = *per_session_state->value().grid_view; | ||
| BOOST_ASSERT(*our_group < grid_view.size()); | ||
| const auto &view = grid_view[*our_group]; |
There was a problem hiding this comment.
It was grid_view[candidate.group].
candidate.group == our_group as we are backing that candidate.
There was a problem hiding this comment.
Мы можем не быть парачейн валидатором и как следствие группы у нас нет. Но мы валидаторы, поэтому мы есть в топологии и должны принимать сообщения от других валидаторов, чтобы формировать блоки с кандидатами.
Comment on lines
29
to
30
| std::vector<std::vector<ValidatorIndex>> groups; | ||
| groups.emplace_back(count); |
There was a problem hiding this comment.
Suggested change
| std::vector<std::vector<ValidatorIndex>> groups; | |
| groups.emplace_back(count); |
turuslan
approved these changes
Oct 1, 2024
xDimon
approved these changes
Oct 1, 2024
Signed-off-by: iceseer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Grid size fixed to
authoritiessize, because we can not be a parachain but still validator.Callback for sends could be skipped if connection already was present.
Added cache for send our view process to insure we don't repeat message twice.
Added additional tests for grid
Possible Drawbacks
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: