1691 consider pvf executor params #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turuslan
approved these changes
Sep 20, 2024
| @@ -3,6 +3,7 @@ timeout = 1000 | |||
|
|
|||
| [relaychain] | |||
| chain = "rococo-local" | |||
| chain_spec_path = "./rococo-local-raw.json" | |||
There was a problem hiding this comment.
Remove chain_spec_path and use [relaychain.genesis.runtimeGenesis.patch].
Or create new zombienet test with chain_spec_path json without --raw flag.
Why use zombie test for this feature?
May use unit test for sessionParams instead, or no test at all.
There was a problem hiding this comment.
Please keep this test with rococo-local
kamilsa
reviewed
Sep 23, 2024
| @@ -3,6 +3,7 @@ timeout = 1000 | |||
|
|
|||
| [relaychain] | |||
| chain = "rococo-local" | |||
| chain_spec_path = "./rococo-local-raw.json" | |||
There was a problem hiding this comment.
Please keep this test with rococo-local
| @@ -119,7 +119,6 @@ namespace kagome::parachain { | |||
| scheduler_{std::move(scheduler)}, | |||
| exe_{exePath()}, | |||
| max_{app_config.pvfMaxWorkers()}, | |||
| timeout_{app_config.pvfSubprocessDeadline()}, | |||
There was a problem hiding this comment.
If we are not using pvf subprocess deadline anymore it should be removed from CLI as well (app_configuration_impl)
iceseer
approved these changes
Sep 23, 2024
ErakhtinB
force-pushed
the
1691-consider-pvf-executor-params
branch
from
ed63178
to
457b22f
Compare
kamilsa
approved these changes
Sep 24, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Closes #1691
Description of the Change
PVF execution timeout is taken from the parameters of runtime, not the config
Possible Drawbacks
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: