Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The function
simplify
is capable of more than we thought. This PR makes sure that any developer is aware of the possibility to use it as a trade-off between precision and memory usage.This PR implements...
Q
:Q::MAX62
(as this is the maximum number that we can instantiate as a constant and fmpz),INV_MAX62
,INV_MAX32
as constants to use for a fair trade-off reg precision and memory-usage.simplify
with these constantssimplify
for
Q
.Testing
Checklist: