[App] Do not instantiate dummy QCoreApplication object (fixes #3714) #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebDieBln
force-pushed
the
App_ParseQtArguments
branch
from
c3ad660
to
e850efd
Compare
SebDieBln
changed the title
SebDieBln
force-pushed
the
App_ParseQtArguments
branch
from
e850efd
to
5f9758b
Compare
|
@m-kuhn I added the doxymentation and since the rebase somehow kicked your comment out of the thread I just give you this hint. |
|
@wonder-sk assigning you as the original author of https://hub.qgis.org/issues/3714 |
SebDieBln
force-pushed
the
App_ParseQtArguments
branch
4 times, most recently
from
8b0c446
to
3bc53f9
Compare
SebDieBln
force-pushed
the
App_ParseQtArguments
branch
from
3bc53f9
to
bb620d4
Compare
SebDieBln
force-pushed
the
App_ParseQtArguments
branch
from
bb620d4
to
337c141
Compare
|
@wonder-sk |
SebDieBln
referenced
this pull request
Jan 16, 2016
New variables for: - @qgis_os_name: eg 'linux','windows' or 'osx' - @qgis_platform: eg 'desktop' or 'server' - @user_account_name: current user's operating system account name - @user_full_name: current user's name from os account (if available) Sponsored by Andreas Neumann
SebDieBln
force-pushed
the
App_ParseQtArguments
branch
from
337c141
to
95708ac
Compare
|
Agreed with @wonder-sk to postpone this PR until QGIS 3.0, where the whole startup process will be reviewed. |
|
@wonder-sk I would like to close this PR. You don't need it as a reminder, do you? |
|
Closing this PR because it will be solved in QGIS 3.0 in a different way. |
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the instantiation of the
QgsApplicationobject and the call toQgsApplication.init()thereby allowing to do the instantiation earlier in the initialization process and removing the need for a dummyQCoreApplicationobject.By doing this all commandline arguments relevant for
QApplication(e.g. -reverse) are hidden from QGIS and no warnings about unknownargumentslayers are produced.I am not a
QApplicationspecialist, so could someone please verify that this does not have any unwanted side effects?