[feature][processing] Complete random raster algorithm collection #36065
Conversation
…orm distribution) and fix header
…al distribution) and fix header fix normal raster
|
@root676 this is GREAT! 😄 Looking at the algorithms, there's a lot of common code between them all (basically everything after the creation of the random distribution is identical). I think we could avoid a lot of the duplicate code by making a common base class for the algorithms. Are you comfortable doing this? |
|
Thanks, Yes I thought about this too... the first time I wanted to implement the algorithms I actually tried to do it with a base class (similar to the Fuzzify algs). But then I ran into some troubles because the random number distribution objects and available raster data types vary (also in type) among all algorithms. I saw no chance in using them as an argument in a pure virtual |
|
I think I have got a solution to the problem - I'll push the changes in a new PR and close this one. What do you think? |
This refactors and completes the recently added work on random number raster layer creation algorithms (see #35835) and reworks the single algorithm implementation proposed in #36065 to a base-algorithm solution which avoids duplicate code. With the new algorithms aimed towards distribution based random number creation, QGIS reaches to the same level of functionality as current ArcGIS random raster creation tools. In total, the PR adds the following algorithms (normal and uniform raster layer creation algs are refactored to be in line the new naming scheme): Create random raster layer (binomial distribution) Create random raster layer (exponential distribution) Create random raster layer (gamma distribution) Create random raster layer (negative binomial distribution) Create random raster layer (normal distribution) Create random raster layer (poisson distribution) Create random raster layer (uniform distribution)
Description
Some random stuff again...
This PR refactors and completes the recently added work on random number raster layer creation algorithms (see #35835.) With the new algorithms aimed towards distribution based random number creation, QGIS reaches to the same level of functionality as current ArcGIS random raster creation tools. In total, the PR adds the following algorithms (normal and uniform raster layer creation algs are refactored to be in line the new naming scheme):
Tests have been added for the algorithms data type choices.
I'm looking forward to comments/questions/reviews/etc.!