Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix all-in-one bundle #37918

Merged
merged 1 commit into from
Aug 3, 2020
Merged

fix all-in-one bundle #37918

merged 1 commit into from
Aug 3, 2020

Conversation

PeterPetrik
Copy link
Contributor

this branch used in nightly2 nightly builds for changes required for qgis/QGIS-Enhancement-Proposals#177

@PeterPetrik PeterPetrik self-assigned this Jul 22, 2020
@github-actions github-actions bot added this to the 3.16.0 milestone Jul 22, 2020
@nyalldawson
Copy link
Collaborator

@PeterPetrik is this still a wip? or is it ready for review?

@PeterPetrik
Copy link
Contributor Author

still WIP for now

@PeterPetrik PeterPetrik changed the title WIP: fix all-in-one bundle fix all-in-one bundle Aug 3, 2020
@PeterPetrik
Copy link
Contributor Author

@nyalldawson ok ready...

Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeterPetrik PeterPetrik merged commit 8ed274b into master Aug 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the macos_deployment_fixes branch August 3, 2020 04:20
@nyalldawson
Copy link
Collaborator

@PeterPetrik any idea why the macos on github build is so fragile at the moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants