[processing] fixed update of toolbox after editing script providers #4206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Argh - sorry. Not sure how I missed those! Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nyalldawson I found some issues with the alglist and the registry, probably stuff that you forgot to update in the python code after moving the registry to core. Please, take a look at this when you have time. Basically, it makes the provider correctly update and the toolbox be refreshed, once a new script is added (or any provider that might change its content at runtime, such as the modeler provider)
If you can think of any other area where similar issues might appear after your changes, let me know so i can check and work on it.