Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sensorthings] Implement subset string support #56670

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

nyalldawson
Copy link
Collaborator

Allows setting custom filters on the layer, using the SensorThings filter syntax.

I've included a custom layer filter GUI for SensorThings layer filters, making it easier for users to craft valid filters using the SensorThings filter language.

@nyalldawson nyalldawson added Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting SensorThings Relates to the OGC SensorThings provider labels Mar 3, 2024
@qgis-bot
Copy link
Collaborator

qgis-bot commented Mar 3, 2024

@nyalldawson
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

qgis-bot commented Mar 3, 2024

@nyalldawson

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@github-actions github-actions bot added this to the 3.38.0 milestone Mar 3, 2024
Copy link

github-actions bot commented Mar 3, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 7acbb12)

Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

I'm curious, why did sensorthings protocol go for a custom filtering syntax?

@nyalldawson
Copy link
Collaborator Author

@nirvn

I'm curious, why did sensorthings protocol go for a custom filtering syntax?

No idea!

@nyalldawson nyalldawson merged commit b17714c into qgis:master Mar 4, 2024
45 checks passed
@nyalldawson nyalldawson deleted the sensor_things_subset_string branch March 4, 2024 10:24
@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. SensorThings Relates to the OGC SensorThings provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants