-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add ScaleBar and MessageLog components to QgsQuick library. #6983
[feature] Add ScaleBar and MessageLog components to QgsQuick library. #6983
Conversation
Not being up to scratch with these components - where is the scalebar rendering actually done? |
@nyalldawson, the actual rendering is done qgsquickscalebar.qml. QML Item is basic block for all of this stuff, similar to QWidget in the qgis_gui library |
Ok, so it's done from scratch? There's no way to re-use QgsScaleBarRenderer here? |
It would be (probably) possible to use |
A QQuickPaintedItem and rasterized widget rendering is not something I'd want to introduce here. Not sure how easy it would be to factor out common code to determine unit / segment number / segment size / ... |
I understand that - I guess I'm just seeing that there's a huge functionality gap between the QML scale bar here and the functionality exposed by QgsScaleBarRenderer. |
True. I think that for first few releases the applications will implement their own QML scalebar and just use the ScaleBarKit to be able to easily access all required input. The QML scale bar in the QgsQuick library is now just a little more than "example" how to properly create customized scale bar with any design. |
Are we good to merge this? I am not sure if we could make good use of QgsScaleBarRenderer in QML world: while the associated QgsScaleBarSettings allow for easy customization of scale bar rendering, the rendered output is still fixed to a particular scale bar design. The beauty of QML is that using the ScaleBarKit developers can produce any scale bar design they can think of... |
Yep, go ahead |
This pull request is a subset of (#6490)
This adds ScaleBar and MessageLog components to QgsQuick library with related classes.
For background information see the associated QEP.