[quick] [feature] Feature attribute panel #7350
Conversation
Allow to show feature attribute form and edit/save the modification of the attributes. Support most frequent QGIS edit widgets such as text edit, value map or external resource (photo capture)
|
|
||
| void QgsQuickSubModel::onRowsAboutToBeInserted( const QModelIndex &parent, int first, int last ) | ||
| { | ||
| emit beginInsertRows( mapFromSource( parent ), first, last ); |
There was a problem hiding this comment.
This is not a signal - do not use "emit"
Same below for onRowsInserted, beginRemoveRows, endRemoveRows
| virtual bool filterAcceptsRow( int source_row, const QModelIndex &source_parent ) const override; | ||
|
|
||
| private: | ||
| QgsQuickAttributeFormModelBase *mSourceModel; //not owned |
|
|
||
| if ( mLayer ) | ||
| { | ||
| QgsAttributeEditorContainer *root; |
|
@m-kuhn is it okay if I merge it or would you like to review that as well? |
|
Thanks for pinging. I'd like to give some feedback, I remember I've had some questions when scrolling through this quickly. |
| public: | ||
|
|
||
| //! Feature fields's roles | ||
| enum FeatureRoles |
There was a problem hiding this comment.
It would probably be a good idea to rename this enum to something with Field, what do you think?
| QgsMessageLog::logMessage( tr( "Cannot update feature" ), | ||
| QStringLiteral( "QgsQuick" ), | ||
| Qgis::Warning ); | ||
| rv = commit(); |
There was a problem hiding this comment.
Might be good to find a better approach to dealing with this in the long run.
I assume, this calls lower-level I/O functions which shouldn't be used in a Q_INVOKABLE because they can make the UI unresponsive.
src/quickgui/qgsquickutils.h
Outdated
| * Returns whether file on path exists | ||
| * \since QGIS 3.4 | ||
| */ | ||
| Q_INVOKABLE bool fileExists( QString path ); |
src/quickgui/qgsquickutils.h
Outdated
| * Extracts filename from path | ||
| * \since QGIS 3.4 | ||
| */ | ||
| Q_INVOKABLE QString getFileName( QString path ); |
src/quickgui/qgsquickutils.cpp
Outdated
| } | ||
| else | ||
| { | ||
| return QUrl( path.arg( "textedit" ) ); |
src/quickgui/qgsquickutils.cpp
Outdated
| const QUrl QgsQuickUtils::getEditorComponentSource( const QString &widgetName ) | ||
| { | ||
| QString path( "qgsquick%1.qml" ); | ||
| QStringList supportedWidgets = { "textedit", |
|
Good job. I haven't looked at the QML code in detail, trusting you there. |
|
@m-kuhn thanks for review and time and I hope we can now all benefit from the common qgis mobile codebase! |
|
Thank you @PeterPetrik , I'll create an updated docker image soon as a new base image for the QField builds, then pieces can be incrementally replaced with core changes. What I am not completely sure yet is how to handle the development process there most efficiently. In explicit, when a file from qgis core needs to be changed, how to bring that in a timely manner to a fully packaged QField apk. |
This pull request is last missing bit from (#6490 )
Allow to show feature attribute form and edit/save the modification
of the attributes. Support most frequent QGIS edit widgets such
as text edit, value map or external resource (photo capture)
For background information see the associated QEP.