Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reproject geometry for GeoJson format from GetFeatureInfo resp… #278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benoitblanc
Copy link
Contributor

@benoitblanc benoitblanc commented Nov 28, 2023

…onse as it is not necessary EPSG:4326 anymore

Hi @manisandro

I'm not sure about this one... Maybe it breaks something elsewhere...

The problem is when we identify objects from external WMS added to the map, the geometry is not highlighted because there is a reprojection for GeoJSON format from EPSG:4326 to the map projection.

GetFeatureInfo from theme. Geometry is highlighted:

image

Import layer as WMS, and identify object. Geometry is not highlighted:

image

Without reprojection from 4326 to the map projection, geometry is highlighted because response is well parsed (it has already the right projection from request parameter):

image

GetFeatureInfo geometry response for geojson format is not necessary EPSG:4326 anymore. It can be other CRS, see this PR: qgis/QGIS#32386

Thanks

…onse as it is not necessary EPSG:4326 anymore
@manisandro
Copy link
Member

Does the GeoJSON feature response contain any CRS information?

@benoitblanc
Copy link
Contributor Author

No it does not...

@manisandro
Copy link
Member

Is this a GeoJSON response returned by QGIS Server? If yes, wouldn't it be better to extend QGIS Server to add a CRS property like

  "crs": {
    "type": "name",
    "properties": {
      "name": "urn:ogc:def:crs:XYZ
      }
    }

?

@benoitblanc
Copy link
Contributor Author

Yes it is a GeoJSON response returned by QGIS Server.

One of my colleagues will add CRS property in QGIS Server soon. Then, I will update this PR by reading this property.

To be continued

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants