Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @main macro conflict with Julia nightly #50

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

Technici4n
Copy link

Hi @qiaojunfeng! Here is a fix for #48 for the 0.3.x series. I don't know if write_diagmat is the correct branch, but it's the only one I could find that is based on the 0.3.3 commit.

Fixes #48.

Related: comonicon/Comonicon.jl#257.

@qiaojunfeng qiaojunfeng changed the base branch from write_diagmat to fix/comonicon October 8, 2024 10:17
@Technici4n
Copy link
Author

Hey thanks for the quick response.

I have fixed the Aqua test by removing the DelimitedFiles dependency. As far as I can tell it is only used through WannierIO now.

To fix the other tests, I also had to disable the wannierize/coopt.jl tests. They rely on iron fixtures that I could not find anywhere in the repo or Git history.

@Technici4n
Copy link
Author

The tests are fine now, but the documentation is failing to build. 😓
There is no docs folder on this branch, so I would say that can be safely ignored?

@qiaojunfeng qiaojunfeng merged commit c677e1b into qiaojunfeng:fix/comonicon Oct 10, 2024
4 checks passed
@qiaojunfeng
Copy link
Owner

Thanks Bruno! I guess you want a new release v0.3.4 for DFTK tests?

@Technici4n
Copy link
Author

Thank you! Yes please. 😄

@Technici4n Technici4n deleted the fix-48 branch October 10, 2024 07:49
qiaojunfeng added a commit that referenced this pull request Oct 11, 2024
For DFTK tests (#50)
@qiaojunfeng
Copy link
Owner

Thank you! Yes please. 😄

OK done
https://github.com/qiaojunfeng/Wannier.jl/releases/tag/v0.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants