Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccurate fitted amplitude in rabi_amplitude_msr #656

Closed
aorgazf opened this issue Dec 6, 2023 · 2 comments · Fixed by #659 or #677
Closed

Inaccurate fitted amplitude in rabi_amplitude_msr #656

aorgazf opened this issue Dec 6, 2023 · 2 comments · Fixed by #659 or #677
Labels
bug Something isn't working calibration
Milestone
Qibocal 0.0.7

Comments

@aorgazf
Copy link
Member

aorgazf commented Dec 6, 2023

Hi,
I've noticed that the fit of the amplitude of the pi pulse in rabi_amplitude_msr returns a value that is close, but incorrect.
image
As you may see in the picture, the returned value is 0.436, but the argmax of the fitting curve is 0.466.
I've tried it on several qubits and it always gives a slightly smaller value.

20231205_spinq10q_.zip
@aorgazf aorgazf added bug Something isn't working calibration labels Dec 6, 2023
@andrea-pasquale
Copy link
Contributor

Hi @aorgazf,
thanks for opening the issue.
From the report it seems that you are using an older version of the code.
Do you see the same bug with the latest version of the code?

andrea-pasquale added a commit that referenced this issue Dec 7, 2023
@andrea-pasquale
fix: Fix rabi fitting by including phase in period estimate
d5445f4 
Fixes #656 but it requires more tests.
@andrea-pasquale andrea-pasquale mentioned this issue Dec 7, 2023
Merged
8 tasks
@andrea-pasquale andrea-pasquale added this to the Qibocal 0.0.7 milestone Dec 7, 2023
@aorgazf aorgazf reopened this Dec 20, 2023
@aorgazf
Copy link
Member Author

aorgazf commented Dec 20, 2023

20231220_spinq10q_09_rabi_amp.zip
Hi @andrea-pasquale, I believe the issue is still there:
image

@andrea-pasquale andrea-pasquale mentioned this issue Dec 20, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working calibration
Projects
None yet
Milestone
Qibocal 0.0.7
Development

Successfully merging a pull request may close this issue.

Improve rabi period estimate qiboteam/qibocal
Hotfix for rabi period estimate qiboteam/qibocal
2 participants
@andrea-pasquale @aorgazf