Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add report failed information in the report. #743

Closed
andrea-pasquale opened this issue Mar 3, 2024 · 2 comments · Fixed by #745
Closed

Add report failed information in the report. #743

andrea-pasquale opened this issue Mar 3, 2024 · 2 comments · Fixed by #745
Assignees
Labels
ui Non-functional features, affecting user interaction
Milestone

Comments

@andrea-pasquale
Copy link
Contributor

Maybe we should write on the report that there has been an attempt, but it failed.

Originally posted by @alecandido in qiboteam/qibolab_platforms_qrc#119 (comment)

@andrea-pasquale
Copy link
Contributor Author

Actually I already discussed this point with @hay-k when working on #707.
It might be non-trivial to do this given that missing Results could mean two different things:

  1. Using qq auto and observing the fit failing.
  2. Using qq acquire which means no fitting.

We might need to store the "execution mode" (auto, acquire, ...) to be able to discriminate the two different cases which I described above.

@alecandido
Copy link
Member

We might need to store the "execution mode" (auto, acquire, ...) to be able to discriminate the two different cases which I described above.

I don't think so, I believe you could make it more isolated.

You could handle a failed fit, dumping a marker file for the failure (I believe we're talking about a "soft" fail, since a hard one, i.e. a crash, would immediately report an error to the user).

if isinstance(output, Failure):
return None, None

@andrea-pasquale andrea-pasquale linked a pull request Mar 8, 2024 that will close this issue
8 tasks
@andrea-pasquale andrea-pasquale self-assigned this Mar 11, 2024
@andrea-pasquale andrea-pasquale added the ui Non-functional features, affecting user interaction label Mar 11, 2024
@andrea-pasquale andrea-pasquale added this to the Qibocal 0.0.8 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Non-functional features, affecting user interaction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants