-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding error message when fitting failed #745
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix_plot_chi2_protocols #745 +/- ##
===========================================================
+ Coverage 96.70% 96.86% +0.15%
===========================================================
Files 108 108
Lines 7497 7490 -7
===========================================================
+ Hits 7250 7255 +5
+ Misses 247 235 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
if target not in node.results: | ||
# plot acquisition data and message for unsuccessful fit | ||
figures = node.task.operation.report(data=node.data, fit=None, target=target)[0] | ||
return figures, "An error occurred when performing the fit." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was unaware we already stored this information somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also had to think about it. We can separate the two cases since only with qq acquire
Results
is None
while in the other case the instance of the class is created and all the dict attributes are filled only if the fit is successful.
Closes #743 .
The following implementation does not require a marker file which I think is better.
Checklist:
master
main
main