Generalizing Mermin to n qubits and adding theta angles for plot #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
I have fixed some of the issues, but I have not been able to iron out everything to conform with Qibocal. I think at this point I might need a hand cleaning things up properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push for the generalization of Mermin to any number of qubits and adding an angle theta that controls the violation.
This will override the other Mermin pull request (#770) when it is completed.
The model for this experiment is the CHSH protocol, as the output should be very similar: a plot with the Mermin value at different angles to track the violation.
I have based myself on those functions for this Mermin generalization, but I am sure there are things to be polished regarding pure qibocal code. Please @Edoardo-Pedicillo and @andrea-pasquale lend me a hand with that.