Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double connection issue #115

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Fix double connection issue #115

merged 1 commit into from
Oct 14, 2022

Conversation

andrea-pasquale
Copy link
Contributor

Closes #114.
As noted by @aorgazf, when running qq the platform was connecting twice to the instruments.
The double connection was caused by:

  • set_backend which for qibolab performs also the connection with the instruments
  • allocating a platform with the updated_runcard, i.e. the platform runcard which is continuosly updated when we run multiple routines.

In this PR I solved this issue by calling set_backend once with the updated_runcard directly.
Let me know what you think.

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #115 (1df4f73) into main (68c4261) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   21.58%   21.58%           
=======================================
  Files          12       12           
  Lines         658      658           
=======================================
  Hits          142      142           
  Misses        516      516           
Flag Coverage Δ
unittests 21.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it works for me. I checked and the new_platform.yml runcard is updated and reloaded every time for the next routine, when launching more than one routines.

@andrea-pasquale
Copy link
Contributor Author

Thanks. I'll merge this now.

@andrea-pasquale andrea-pasquale merged commit c5654d4 into main Oct 14, 2022
@andrea-pasquale andrea-pasquale deleted the fix_platform branch October 14, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform is loaded twice on every qibocal action
3 participants