-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes #122
Minor fixes #122
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
- Coverage 24.41% 18.86% -5.55%
==========================================
Files 12 19 +7
Lines 684 1044 +360
==========================================
+ Hits 167 197 +30
- Misses 517 847 +330
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@scarrazza coverage is decreasing because of the logger, shall include some tests now? |
@scarrazza as discussed yersterday I will merge this now. Tests are not passing only because of coverage we will fix this in another PR. |
In this PR I've fixed a few minor problems raised in #94 and #80.
In particular:
the output file. It is possible to change the log level using the environment variable
QIBOCAL_LOG_LEVEL
.less -R output_file
I've also updated the
pyproject.toml
by adding almfit
dependency since it is no longer a qibolab dependency and it is needed for all the fitting methods that we have in qibocal.Checklist: