Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added web visualization of multiple data reports #156

Merged

Conversation

DavidSarlle
Copy link
Contributor

This branch implements the possibility to select multiple saved reports to visualize data in the same webpage using qq-live. Unlike qq-compare, this function will show multiple saved reports without checking if the selected reports are comparable.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #156 (834090d) into alvaro/fast_calibrate_qubit_states_pr (6b80604) will decrease coverage by 0.29%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@                            Coverage Diff                            @@
##           alvaro/fast_calibrate_qubit_states_pr     #156      +/-   ##
=========================================================================
- Coverage                                  18.76%   18.47%   -0.30%     
=========================================================================
  Files                                         13       13              
  Lines                                        943      958      +15     
=========================================================================
  Hits                                         177      177              
- Misses                                       766      781      +15     
Flag Coverage Δ
unittests 18.47% <0.00%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibocal/web/app.py 0.00% <0.00%> (ø)
src/qibocal/web/server.py 0.00% <0.00%> (ø)

@scarrazza scarrazza added the enhancement New feature or request label Nov 17, 2022
@scarrazza scarrazza added this to the First release milestone Nov 17, 2022
Base automatically changed from david/qq-compare to alvaro/fast_calibrate_qubit_states_pr November 22, 2022 12:59
Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this @DavidSarlle.
You can find below a few comments.

A possible suggestion maybe not related to this PR. When the qq-compare command is failing it would be cool to show the error on the same page instead of showing it in a new web page:
Screenshot from 2022-12-09 10-35-34

src/qibocal/web/server.py Outdated Show resolved Hide resolved
@DavidSarlle
Copy link
Contributor Author

Thanks for implementing this @DavidSarlle. You can find below a few comments.

A possible suggestion maybe not related to this PR. When the qq-compare command is failing it would be cool to show the error on the same page instead of showing it in a new web page: Screenshot from 2022-12-09 10-35-34

Implemented

Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @DavidSarlle.
This PR is ready to merge in my opinion.

@scarrazza scarrazza merged commit 85dbca7 into alvaro/fast_calibrate_qubit_states_pr Dec 13, 2022
@scarrazza scarrazza deleted the david/report-concatenate branch December 13, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants