Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pulse sequence creation in Rabi routines #196

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Conversation

aorgazf
Copy link
Member

@aorgazf aorgazf commented Jan 13, 2023

Hi,
This PR fixes a bug in the creation of the pulse sequences in some Rabi experiments that was introduced in PR #155.
Thanks @maxhant
Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@aorgazf aorgazf added bug Something isn't working urgent labels Jan 13, 2023
@aorgazf aorgazf self-assigned this Jan 13, 2023
@aorgazf aorgazf changed the title Fix pulse creation in Rabi routines Fix pulse sequence creation in Rabi routines Jan 13, 2023
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #196 (0fb12c7) into main (e74a842) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   36.07%   36.07%           
=======================================
  Files          19       19           
  Lines        1192     1192           
=======================================
  Hits          430      430           
  Misses        762      762           
Flag Coverage Δ
unittests 36.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@scarrazza scarrazza added this to the First release milestone Jan 13, 2023
@scarrazza scarrazza merged commit 033e635 into main Jan 13, 2023
@scarrazza scarrazza deleted the alvaro/fix_rabis_pr branch January 13, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working urgent
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants