Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update_platform_runcard method #197

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Fix update_platform_runcard method #197

merged 4 commits into from
Jan 13, 2023

Conversation

andrea-pasquale
Copy link
Contributor

Fixes the behavior of the method update_platform_runcard of the ActionBuilder that was broken after merging PR #155. After executing all the calibration routines the user will find in the output folder a file new_platform.yml with an updated platform runcard. All the parameters in the runcard are updated sequentially.

I've fixed in a typo in the routine qubit_spectroscopy.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@andrea-pasquale andrea-pasquale added the bug Something isn't working label Jan 13, 2023
@andrea-pasquale andrea-pasquale added this to the First release milestone Jan 13, 2023
@andrea-pasquale andrea-pasquale self-assigned this Jan 13, 2023
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #197 (951957d) into main (e74a842) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   36.07%   36.07%           
=======================================
  Files          19       19           
  Lines        1192     1192           
=======================================
  Hits          430      430           
  Misses        762      762           
Flag Coverage Δ
unittests 36.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@scarrazza scarrazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@scarrazza scarrazza merged commit 5716b91 into main Jan 13, 2023
@scarrazza scarrazza deleted the fix_update_platform branch January 13, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants